Support Universal Assisted Model #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job PR-90-252636c is done. |
shreyash2106
approved these changes
Nov 5, 2024
suzhoum
reviewed
Nov 6, 2024
| if self.assistant_tokenizer_name: | ||
| assistant_tokenizer = AutoTokenizer.from_pretrained(self.assistant_tokenizer_name) | ||
| self.hf_generate_params["assistant_tokenizer"] = assistant_tokenizer | ||
| self.hf_generate_params["tokenizer"] = self.tokenizer |
There was a problem hiding this comment.
It might be more logical to move Line 93 out of the if statement and place after Line 81?
There was a problem hiding this comment.
this line is usually not needed, but it is compulsory if there is an assistant tokenizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
PR to support universal assisted model, see https://huggingface.co/docs/transformers/main/en/generation_strategies#universal-assisted-decoding for more details.
Related Issue
[Link to the related issue, if applicable]
Type of Change
Checklist
Additional Information
[Any additional information, configuration, or data that might be necessary to reproduce the issue or test the PR]
Screenshots (if appropriate)
[Add screenshots to help explain your changes]
Performance Impact
[Describe any performance impact this change may have]
Backwards Compatibility
[Describe any backwards incompatible changes and how you've addressed them]
Dependency Changes
[List any new dependencies introduced or removed]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.